From 75f0463bc61c45473efa451c4f02b9fb174924c2 Mon Sep 17 00:00:00 2001 From: Jose Falanga Date: Wed, 19 Aug 2026 16:20:21 -0300 Subject: [PATCH] readability: extract magic constants - HTTP_TIMEOUT_MS for HTTP connection/request timeout - SCREENSHOT_REGEX_PATTERN for itch.io screenshot URL regex --- core/boxart_itch.gd | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/core/boxart_itch.gd b/core/boxart_itch.gd index 18f2292..ed93c72 100644 --- a/core/boxart_itch.gd +++ b/core/boxart_itch.gd @@ -12,6 +12,8 @@ extends BoxArtProvider const _boxart_dir := "user://boxart/itch" const _meta_cache_file := "itch_art_meta.json" +const HTTP_TIMEOUT_MS := 15000 +const SCREENSHOT_REGEX_PATTERN := "https://img\\.itch\\.zone/aW1hZ2Uv[^\"]*/original/[^\"]*" @export var use_caching: bool = true var http_image := HTTPImageFetcher.new() @@ -225,7 +227,7 @@ func _fetch_game_page_metadata(game: Dictionary) -> Dictionary: if err != OK: logger.warn("HTTP connect failed for %s: %d" % [page_url, err]) return {} - var deadline := Time.get_ticks_msec() + 15000 + var deadline := Time.get_ticks_msec() + HTTP_TIMEOUT_MS while http.get_status() == HTTPClient.STATUS_CONNECTING or http.get_status() == HTTPClient.STATUS_RESOLVING: http.poll() if Time.get_ticks_msec() > deadline: @@ -239,7 +241,7 @@ func _fetch_game_page_metadata(game: Dictionary) -> Dictionary: return {} http.request(HTTPClient.METHOD_GET, "/" + "/".join(parts.slice(3)), PackedStringArray()) - deadline = Time.get_ticks_msec() + 15000 + deadline = Time.get_ticks_msec() + HTTP_TIMEOUT_MS while http.get_status() == HTTPClient.STATUS_REQUESTING: http.poll() if Time.get_ticks_msec() > deadline: @@ -268,7 +270,7 @@ func _fetch_game_page_metadata(game: Dictionary) -> Dictionary: return {} var shot_re := RegEx.new() - shot_re.compile("https://img\\.itch\\.zone/aW1hZ2Uv[^\"]*/original/[^\"]*") + shot_re.compile(SCREENSHOT_REGEX_PATTERN) var screenshots: Array = [] for m in shot_re.search_all(html): var url: String = m.get_string(0)