jose/itchio-opengamepadui-plugin
1
0
Fork 0
Code Issues Pull requests Projects Releases 8 Packages Wiki Activity Actions

readability: rename constants, variables, extract enums across plugins

Browse source 
- itch: UPPER_CASE constants, CACHE_NAMESPACE, butler_process/rpc_socket/connection_state, LOGIN_METHOD enum, SETTINGS_SECTION, signal handler renames
- artprovider: UPPER_CASE constants, _enriched_meta, _find_game_dict, dead code removal, named poll intervals
- session-switch: MAX_POLL_FRAMES, _poll_for_power_menu, BUTTON_LABEL const
This commit is contained in:
Jose Falanga 2026-08-19 16:41:31 -03:00
parent 7ee08ac571
commit 97c1519833
4 changed files with 61 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

15
plugin.gd
View file

@ -14,10 +14,13 @@ var notification_manager := load("res://core/global/notification_manager.tres")
var settings_menu := load("res://plugins/itch/core/itch_settings.tscn") as PackedScene
var icon := preload("res://plugins/itch/assets/itch.svg")
const SETTINGS_SECTION := "plugin.itch"
enum LOGIN_METHOD { API_KEY = 0, PASSWORD = 1 }
var itch: ItchClient
var api_key := settings_manager.get_value("plugin.itch", "api_key", "") as String
var login_method := settings_manager.get_value("plugin.itch", "login_method", 0) as int
var username := settings_manager.get_value("plugin.itch", "username", "") as String
var api_key := settings_manager.get_value(SETTINGS_SECTION, "api_key", "") as String
var login_method := settings_manager.get_value(SETTINGS_SECTION, "login_method", 0) as int
var username := settings_manager.get_value(SETTINGS_SECTION, "username", "") as String
func _ready() -> void:
@ -26,7 +29,7 @@ func _ready() -> void:
# Load the itch client. This spawns butlerd in the background and
# manages the JSON-RPC connection to it.
itch = load("res://plugins/itch/core/itch_client.tscn").instantiate()
itch.bootstrap_finished.connect(_on_client_start)
itch.bootstrap_finished.connect(_on_bootstrap_finished)
itch.client_ready.connect(_on_client_ready)
itch.logged_in.connect(_on_client_logged_in)
add_child(itch)
@ -37,7 +40,7 @@ func _ready() -> void:
# Triggers when butlerd has been spawned
func _on_client_start() -> void:
func _on_bootstrap_finished() -> void:
if not itch.client_started:
var notify := Notification.new("Unable to start the itch.io (butlerd) client")
notify.icon = icon
@ -52,7 +55,7 @@ func _on_client_ready() -> void:
# logins from previous runs without any stored tokens on our side.
if await itch.try_saved_login():
return
if login_method == 0:
if login_method == LOGIN_METHOD.API_KEY:
# API key login
if api_key == "":
var notify := Notification.new("itch.io API key required")